fix(cli-repl): Fix depcheck with a more permissive workaround for the searchParams type #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
approved these changes
Oct 15, 2024
addaleax
reviewed
Oct 17, 2024
| const tlsCertificateKeyFilePassword = searchParams.get( | ||
| const searchMap = searchParams as Map<keyof DevtoolsConnectOptions, string>; | ||
| const tlsCertificateKeyFile = searchMap.get('tlsCertificateKeyFile'); | ||
| const tlsCertificateKeyFilePassword = searchMap.get( |
There was a problem hiding this comment.
This could have used a bit more description of what it is fixing, plus maybe a TODO comment to revert it at some point (if that is possible) since we're losing type safety here?
There was a problem hiding this comment.
Good point, I actually wonder if the depCheck bump would allow us to revert this now; will check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.