-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add support for Foliage ticket filing MONGOSH-1869 #2251
Conversation
.evergreen/evergreen.yml.in
Outdated
@@ -1112,7 +1112,7 @@ tasks: | |||
### | |||
<% for (const { id, nShort, nVersion, mShort, mVersion, skipNodeVersionCheck, packageName } of ALL_UNIT_TESTS) { %> | |||
- name: test_<% out(id) %> | |||
tags: <% out(["unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %> | |||
tags: <% out(["assigned_to_jira_team_mongosh_mongosh", "unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's also foliage_check_task_only
which will create tickets for the whole task instead of a specific test failure but I think we should be fine regardless?
only worry I have right now is that because of our setup we might end up with a spam of test failures for a task on every platform if 1 test fails across all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah, I can see your concern ... but our task names already include platform names, I guess making it a per-task thing wouldn't actually help all that much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is basically unavoidable without refactoring our tasks a lot more, we could just put it in and see what happens I suppose
.evergreen/evergreen.yml.in
Outdated
@@ -1112,7 +1112,7 @@ tasks: | |||
### | |||
<% for (const { id, nShort, nVersion, mShort, mVersion, skipNodeVersionCheck, packageName } of ALL_UNIT_TESTS) { %> | |||
- name: test_<% out(id) %> | |||
tags: <% out(["unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %> | |||
tags: <% out(["assigned_to_jira_team_mongosh_mongosh", "unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah, I can see your concern ... but our task names already include platform names, I guess making it a per-task thing wouldn't actually help all that much?
Merging this as that is the only way to really test Foliage and should hopefully be useful enough for now. Created MONGOSH-1907 for a future follow-up with E2E tests. |
Following https://github.com/10gen/mothra/pull/1196, we should be able to use Foliage.
This is largely replicating changes done in mongodb-js/compass#6168.
Unfortunately we can't really test this without putting it in main first as Foliage doesn't file tickets for failures in patches. It files them based on mainline commits.
Only worry I have right now is that because of our setup we might end up with a spam of test failures for a task on every platform if 1 test fails across all of them