Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONGOSH-237 - Make print() and console.log() available #184

Merged
merged 1 commit into from
Oct 13, 2020
Merged

MONGOSH-237 - Make print() and console.log() available #184

merged 1 commit into from
Oct 13, 2020

Conversation

addaleax
Copy link
Contributor

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Anemy
Anemy approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice - this is real good for playgrounds.

alenakhineika
alenakhineika approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - works great! 👏 including previously broken telemetry ✨

@addaleax addaleax merged commit 93271f4 into master Oct 13, 2020
@addaleax addaleax deleted the monogsh-237-dev branch October 13, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenakhineika alenakhineika alenakhineika approved these changes

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @Anemy @alenakhineika