VSCODE-200: Open mongodb shell with git bash #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-200
Fixes #186
This PR adds support for launching MongoDB shell when the user has their default shell set to git bash.
It also fixes an issue with loading files with spaces in them.
The way we do the environment passing for these different shell environments is a bit manual and hacky. I've looked around for a bit for a node package which provides support for building the shell command for various shells/environments but haven't found one. Do ya'll know of one? I think this works for now but it would be nice to have a quick catch all to prevent any lack of support for other environments.
Manually tested with SSL certs on windows (with a cert file with a space in it which is how I came across that other bug xD).