feat(VSCODE-168): Add resources panel to overview page #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Nov 17, 2020
src/views/webview-app/components/resources-panel/resources-panel.tsx
Outdated
Show resolved
Hide resolved
|
I think we can remove the @Sgrinfy are you happy with how this looks? |
rose-m
reviewed
Nov 18, 2020
src/views/webview-app/components/resources-panel/resources-panel.less
Outdated
Show resolved
Hide resolved
src/views/webview-app/components/resources-panel/resources-panel.less
Outdated
Show resolved
Hide resolved
src/views/webview-app/components/resources-panel/resources-panel.less
Outdated
Show resolved
Hide resolved
src/views/webview-app/components/resources-panel/resources-panel.less
Outdated
Show resolved
Hide resolved
|
@rose-m Pushed up changes based on your feedback - thanks! Also removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-168
This PR adds a resources panel to the overview page.
If possible, when reviewing, please take a look at the urls just to be sure I haven't missed something and they all make sense.
@mmarcon , does the telemetry screen id
overviewResourcesPanelwork for these links? How are the linkIds? https://github.com/mongodb-js/vscode/pull/208/files#diff-6e516781f35b2dd2aefe6b054aff9448af2c9434e6ed261f87eee4b401059d2bR19*Gif and screenshot are up to date except
MongoDB Cloudis removed from theContributelist.light mode
some other theme