feat(VSCODE-170): Update connect form routes to overview page connect form #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
approved these changes
Nov 20, 2020
|
@rose-m Thanks. Sounds good - mentioned it to Claudia - going to merge this, but can wrap that into the next ticket since it's a two liner with an icon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-170
This PR updates how we show the connect form when the commands to navigate to the connect form are performed. Previously we would show a standalone connect form. Now we show the overview page (and then a user can select the form). If we find users want a direct link to the connection form back, we can always revisit.
Open Q:
Are there any places we want to explicitly link the overview page? We have a command palette command, however we could add a link in the
Helppanel for instance.