feat(VSCODE-196): Show connection form error in connection form #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
changed the title
Anemy
deleted the
VSCODE-196/show-connection-form-error-in-connection-form
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-196
This PR updates how we show errors in our connection form. Previously we would show descriptive errors in vscode alerts. This updates the behavior to make the error in the connection form the verbose one, and move away from showing verbose vscode notifications, to show the error in the form ui.
Wrapped a bit of cleanup in too, previously we were storing the connecting connection identifier as a number, now we use a uuid or the connection's id. The connection form now also stores the connecting connection identifier, so it can ignore overridden connection attempt results.
This PR should also handle the case where the user has closed the form window where they are attempting to connect. Previously this would cause a silent background error.