fix(VSCODE-118): Fix opening binary _id #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Dec 4, 2020
| @@ -286,7 +289,10 @@ export default class PlaygroundController { | |||
| .then(undefined, (error) => { | |||
| log.error('Evaluate playground with cancel modal error', error); | |||
|
|
|||
| return resolve(undefined); | |||
There was a problem hiding this comment.
typescript & lint wasn't happy with this line which makes sense. This is an unrelated change.
I'll make a ticket to look into adding lint checks to this project.
rose-m
approved these changes
Dec 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution introduced in #213 didn't fully cover all the opening of documents with different typed
_idcases. When we open documents in vscode, in the original solution we sort of hackily added the _id as a ejsoned string on the document's uri in vscode. This doesn't work well because we have to ejson stringify, parse, uri encode, uri decode, and also we're bound by uri constraints like character limits in the query.This PR updates how we pass a document's
_idto the document provider in vscode. It adds a store which we then pass a reference to, so that we can avoid any encoding/decoding of the_idvalue.On the upcoming editing documents work we may revisit how we show these documents so that we can be a bit more generalized and we can accommodate opening documents from playground results.
Tested with binary ids with
+characters, numberlongs, and some other possible _ids.Should fix #131 as well.