fix: Use connected connection model options VSCODE-234 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d against the correct connection
alenakhineika
approved these changes
Feb 9, 2021
| } | ||
|
|
||
| this._activeConnectionCodeLensProvider?.refresh(); | ||
| const connectionDetails = dataService.getConnectionOptions(); |
There was a problem hiding this comment.
I feel like connectionDetails name is confusing because we get connectionOptions from dataservice. Probably should be renamed in the dataservice since it includes options and URL and not just options.
There was a problem hiding this comment.
Agreed. I think this is a bit of a hack in general. Will be nice to update to new driver and clean up some of this.
| ); | ||
|
|
||
| return resolve(undefined); | ||
| } |
|
Great refactoring of the playground controller! It will definitely ensure that playgrounds are running on the proper connection. Does this fix also address the directConnection issue? |
|
@alenakhineika Here are the connection options being used to connect on the language server now (ssh tunnel connection): |
Anemy
deleted the
VSCODE-234/use-connection-options-from-data-service-for-playgrounds
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-234
This PR updates how we fetch connection details to pass to playgrounds, so that we take the options which were used when connecting. This should fix #249 since now we'll use the options with
directionConnectionset: https://github.com/mongodb-js/connection-model/blob/master/lib/connect.js#L228 Alternatively we could setdirectConnectionmanually, or set it in connection options in connection-model.This PR also adds a check so that we only run a playground when the connected connection's id matches the connection id passed when running the playground.
The way we're handling these ssl files, and connection options is a bit confusing. I think we can clear it up a bit in future, especially once we upgrade to 4.0. We can remove sslKey from our model and avoid any ssl file reading. I also think how we're deriving these connection options from the data service post connection is a bit error prone. I think some better defaults on the connection model or how its originally parsed could clear it up a bit. Not for this PR though.