-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete details #267
Autocomplete details #267
Conversation
As a side note, if we had a flag for deprecated methods that the extension can read when it loads the shell API symbols, we could tag those |
This way, it does not crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! 😍 LGTM - but I'll let the others give their full approval!
Wow 😄! Would it be possible to move this to be part of the interface of the shell autocompleter? Is some change more, but if this is not urgent it would be good so we don't leak shell internals around and we'd get the same in all the shells. |
Never mind, forgot that the shell auto-completer works in a different way, maybe when we put them back together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
RE failing to update mongosh deps to latest, it's probably related to #219 and for sure a few other things, there were a bunch of changes in latest mongosh and we definitely should take some time and update vscode to latest |
Given that we are pulling the autocomplete symbols from the shell API, we can pull the documentation details from there too.
Description
This change pulls in the shell's
i18n
package and uses that to enrich the shellCompletionItem
s with an example and a one-sentence explanation of what the command does. Unfortunately it does not look like the CompletionItem API supports links.Checklist
Motivation and Context
Open Questions
That string that is passed to
Translator.translate()
is overly verbose but there does not seem to be a way around that.Dependents
Types of changes