-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create dbs and collections using playgrounds VSCODE-262 #294
feat: create dbs and collections using playgrounds VSCODE-262 #294
Conversation
src/editors/playgroundController.ts
Outdated
const serverVersion = buildInfo.version.replace(/-.*$/, ''); | ||
|
||
if (semver.satisfies(serverVersion, '>= 5.0')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const serverVersion = buildInfo.version.replace(/-.*$/, ''); | |
if (semver.satisfies(serverVersion, '>= 5.0')) { | |
const serverVersion = buildInfo.versionArray[0]; | |
if (serverVersion >= 5) { |
since versionArray
is the machine-accessible variant of version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced version with versionArray.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
Change the way on how we create dbs and collections. Instead of using input boxes for db and collection names open a new playground template.
We should use one template for db and collection creation since there is no way to create db without a collection
The template should be a valid JS template with placeholders for db and collection names
If we create a collection for the existing db the template should pre-populate the db name
Show a time-series prototype form only for Server 5.0 and later.
Checklist
Motivation and Context
Types of changes