Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mongosh the default shell #306

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Make mongosh the default shell #306

merged 2 commits into from
Jun 28, 2021

Conversation

mmarcon
Copy link
Member

@mmarcon mmarcon commented Jun 25, 2021

Description

As we approach the GA of the new MongoDB Shell (mongosh), let's make it the default.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mmarcon mmarcon requested a review from Anemy June 25, 2021 14:38
@mmarcon
Copy link
Member Author

mmarcon commented Jun 25, 2021

Looks like I also needed to adjust a bunch of tests. I'll do that shortly.

Anemy
Anemy approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I should probably update my system mongosh now...
Screen Shot 2021-06-25 at 3 01 54 PM

@mmarcon mmarcon merged commit fc18e43 into master Jun 28, 2021
@mmarcon mmarcon deleted the mongosh-default-shell branch June 28, 2021 06:05
@Anemy Anemy mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmarcon @Anemy