feat(playgrounds): Show code lens at end of selection #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chatting and pairing on this w/ @alenakhineika - we were thinking until we decide if code actions are a better alternative we could go back to putting the code lenses at the bottom of selections just to hopefully improve that ux.
This PR has a few fixes for situations where we weren't showing codelenses, for instance if a user had a multi selection and the last selection was an empty space it wouldn't show a code lens.
In cases where the selection includes the end of the playground, and that last line is not empty, we now add an empty line so we can show a code lens nicely at the end. This is shown in the video below. I don't totally remember, but I think this maybe have been the reason we changed to putting code lenses on top.
difference.show.code.lens.mp4