Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tree-explorer): sort dbs in the tree by name #488

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat(tree-explorer): sort dbs in the tree by name #488

merged 1 commit into from
Jul 10, 2023

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Feb 28, 2023

Looks like we were defaulting to the server's returned ordering, this pr makes the databases in the list sorted. While most of the databases returned from MongoDB are already sorted, admin, local, and config appear before others alphabetically. These changes make those databases appear alphabetically as well as ensures databases that might return databases differently, (maybe Atlas Data Federation or Cosmos), order the same.

Reported in #485

Before merging I'll add a test.
^ Just read this after merging 🙈 will open a new pr.

@lerouxb
Copy link
Contributor

lerouxb commented Mar 3, 2023

Do we want this? Feels right to me that the "system" dbs are listed first or at least separately without being mixed in with the others. Might be worth bringing up with product/design.

@Anemy Anemy merged commit 7977fdf into main Jul 10, 2023
@Anemy Anemy deleted the sort-dbs branch July 10, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants