Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collection with dots in the name disappears from the suggestions list VSCODE-407 #514

Merged
merged 4 commits into from
Apr 20, 2023
Merged

fix: collection with dots in the name disappears from the suggestions list VSCODE-407 #514

merged 4 commits into from
Apr 20, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Apr 20, 2023 •
edited
Loading

Description

The PR fixes the issue #513, when collections with . in the name disappeared from the suggestions list.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika changed the title fix: collection with dots in the namespace disappears from the suggestions list VSCODE-407 fix: collection with dots in the name disappears from the suggestions list VSCODE-407 Apr 20, 2023
addaleax
addaleax approved these changes Apr 20, 2023
View reviewed changes
src/language/mongoDBService.ts Outdated Show resolved Hide resolved
@alenakhineika alenakhineika merged commit 7b10092 into main Apr 20, 2023
@alenakhineika alenakhineika deleted the VSCODE-407-fix-collections-with-dots-completion branch April 20, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @addaleax