chore: add new utm attributes to all mongodb links VSCODE-356 #526
Conversation
| const atlas = new HelpLinkTreeItem( | ||
| 'Create Free Atlas Cluster', | ||
| `https://mongodb.com/products/vs-code/vs-code-atlas-signup?utm_campaign=vs-code-extension&utm_source=visual-studio&utm_medium=product${ajsAid}`, |
There was a problem hiding this comment.
With the change, we will be missing out on utm_campaign and ajsAid query params. Just confirming if this is intentional?
There was a problem hiding this comment.
Yes, in the ticket:
There are some links that already have UTMs, like the "Create Free Atlas Cluster" link below, they can all be standardized to be the same:
https://www.mongodb.com/products/vs-code/vs-code-atlas-signup?utm_campaign=vs-code-extension&utm_source=visual-studio&utm_medium=product&ajs_aid=undefined
can become:
https://www.mongodb.com/products/vs-code/vs-code-atlas-signup?utm_source=vscode&utm_medium=product
|
@Anemy @himanshusinghs does #526 (comment) answers your concerns about removing |
|
Ahh wow sorry I didn't see that. We are doing precisely what is mentioned in the ticket so I believe it should be fine. |
|
@gribnoysup I'm thinking it could be an accident that in the example it's removed. I pinged them on the ticket. Changes here look good, let's wait to hear back to be safe. |
There was a problem hiding this comment.
Looks like there's one link in the webview we might want to update, in atlast-cta.tsx
Currently it has the utm_source = visual-studio and not vscode and has the old utm_campaign. Just a note, I'm not sure if src/utils/links.ts will bundle with it automatically as it's involved in a separate webpack.
https://github.com/mongodb-js/vscode/blob/main/src/views/webview-app/components/atlas-cta/atlas-cta.tsx#L22
Left one comment on a test we might be missing now
|
Yeah, there are a bunch of other I missed, moving them to the |
gribnoysup
force-pushed
the
vscode-356-add-utm-to-links
branch
from
7fa8ea4 to
933278e
Compare
This patch adds new utm attrs to all mongodb urls in the plugin. Moved all the links to one place so that it should hopefully be hard to miss adding those when new urls will be added