Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check secretStorageLocation instead of storageLocation #583

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix: check secretStorageLocation instead of storageLocation #583

merged 3 commits into from
Aug 23, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Aug 22, 2023 •
edited
Loading

Description

Check secretStorageLocation instead of storageLocation to find connections that have not been migrated yet.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

himanshusinghs
himanshusinghs approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@alenakhineika alenakhineika merged commit d1ba961 into main Aug 23, 2023
@alenakhineika alenakhineika deleted the fix-connections-migration branch August 23, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshusinghs himanshusinghs himanshusinghs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @himanshusinghs