Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(playgrounds): stringify non-string types for playground output VSCODE-466 #590

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix(playgrounds): stringify non-string types for playground output VSCODE-466 #590

merged 2 commits into from
Sep 5, 2023

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Sep 1, 2023 •
edited
Loading

VSCODE-466

Happens with both console.log and print.
Using the following example:

console.log('test');
console.log({a: 2});
console.log(['a', {a: 3}])
before after
Screenshot 2023-09-01 at 12 35 06 PM Screenshot 2023-09-01 at 12 33 07 PM

alenakhineika
alenakhineika approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yeah having a test would be nice!

@Anemy Anemy merged commit c5c6b70 into main Sep 5, 2023
@Anemy Anemy deleted the VSCODE-466-fix-print-playground-output branch September 5, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenakhineika alenakhineika alenakhineika approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anemy @addaleax @alenakhineika