Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCODE-505: stream support in UI #643

Merged
merged 2 commits into from
Jan 10, 2024
Merged

VSCODE-505: stream support in UI #643

merged 2 commits into from
Jan 10, 2024

Conversation

shaketbaby
Copy link
Contributor

Description

When connected to an Atlas Stream Processing Instance:

  • Updated explorer tree to show a list of stream processors
  • Open a streams specific playground template
  • Open a create stream processor playground when add stream processor button/menu item is clicked

Checklist

  • New tests and/or benchmarks are included

Motivation and Context

  • New feature
  • Dependency update

Types of changes

  • Minor (non-breaking change which adds functionality)

@shaketbaby shaketbaby added the enhancement New feature or request label Jan 3, 2024
@shaketbaby shaketbaby self-assigned this Jan 3, 2024
Base automatically changed from VSCODE-504-streams-support-in-playground to main January 4, 2024 22:09
@shaketbaby shaketbaby force-pushed the VSCODE-505-streams-support-ui branch from 1f77f6b to 0c315aa Compare January 4, 2024 22:25
Anemy
Anemy reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a couple comments, mostly small things on the template text. Nice work! Gave it a try and it is working smooth.

src/mdbExtensionController.ts Show resolved Hide resolved
src/explorer/connectionTreeItem.ts Outdated Show resolved Hide resolved
src/templates/playgroundCreateStreamProcessorTemplate.ts Outdated Show resolved Hide resolved
src/templates/playgroundCreateStreamProcessorTemplate.ts Outdated Show resolved Hide resolved
src/templates/playgroundStreamsTemplate.ts Outdated Show resolved Hide resolved
src/templates/playgroundStreamsTemplate.ts Outdated Show resolved Hide resolved
src/templates/playgroundStreamsTemplate.ts Outdated Show resolved Hide resolved
src/templates/playgroundStreamsTemplate.ts Outdated Show resolved Hide resolved
@shaketbaby shaketbaby force-pushed the VSCODE-505-streams-support-ui branch from 0c315aa to 12c6e99 Compare January 9, 2024 23:39
@shaketbaby shaketbaby merged commit 6f2017f into main Jan 10, 2024
5 checks passed
@shaketbaby shaketbaby deleted the VSCODE-505-streams-support-ui branch January 10, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

@alenakhineika alenakhineika Awaiting requested review from alenakhineika

Assignees

@shaketbaby shaketbaby

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaketbaby @Anemy