Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add export to Rust and PHP VSCODE-411 #676

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Jan 24, 2024

Description

Adding Rust and PHP to the language export commands & codeActions. I feel like the playground actions part could be refactored, but that can be a separate PR.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@paula-stacho paula-stacho marked this pull request as ready for review January 24, 2024 17:48
@@ -24,6 +24,9 @@ suite('Playground Selected CodeAction Provider Test Suite', function () {

const extensionContextStub = new ExtensionContextStub();

const EXPORT_LANGUAGES_CODEACTIONS_COUNT = 8;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paula-stacho paula-stacho merged commit 4606982 into main Jan 25, 2024
5 checks passed
@paula-stacho paula-stacho deleted the VSCODE-4111-rust-php branch January 25, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants