fix: include export mode when retrieving import statements VSCODE-440

[paula-stacho]

Description

The getImports transpiler method expects two arguments

• mode: 'Pipeline' | 'Query' | 'Delete Query' | 'Update Query'
• driverSyntax: boolean

source: https://github.com/mongodb-js/compass/blob/92f267e369d188c5f11c2450f3d65f73725558e4/packages/bson-transpilers/codegeneration/CodeGenerationVisitor.js#L94

In VSCode we have only two modes:

• when an array is selected -> aggregate ~ Pipeline
• when an object is selected -> find ~ Query

The main fix is sending two arguments (which allows for the second to be read correctly).

As far as I can tell, the exact mode only matters for Java. Given that the method applied is a wild guess, user might need to adjust the import together with the code anyway, but at least the imports now match the code.

Steps to reproduce:

• select an object/array in the playground
• export to Java
• include Driver Syntax and Import Statements

Current behaviour:

The import statements are only

import org.bson.Document;

After the fix:

import org.bson.Document;
import com.mongodb.MongoClient;
import com.mongodb.MongoClientURI;
import com.mongodb.client.MongoCollection;
import com.mongodb.client.MongoDatabase;
import org.bson.conversions.Bson;
import java.util.concurrent.TimeUnit;
import org.bson.Document;

If you've selected an array, you'll also see -

import com.mongodb.client.AggregateIterable;

And for an object -

import com.mongodb.client.FindIterable;

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

I feel weird about the test placement, but this was the best I found.
I made an attempt to at least separate the test into three smaller pieces. I thought it would work since mocha runs the tests sequentially, but it didn't work and I gave up 😅 . I haven't worked with mocha for a long time, so maybe I'm missing something

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[alenakhineika]

Can we add one more test? :) The include driver syntax and then add import statements test, which would do all the steps that the include driver syntax (only) does. And then call once again await vscode.commands.executeCommand(actionCommand.command); to emulate the case when a user runs the same playground to export to language and sees the state of the code lenses from the previous run, like Include Import Statements | Exclude Driver Syntax | Exclude Driver Syntax. And then we call:

await vscode.commands.executeCommand(
  'mdb.changeExportToLanguageAddons',
  {
    ...mdbTestExtension.testExtensionController._playgroundController._exportToLanguageCodeLensProvider._exportToLanguageAddons,
     importStatements: true // We set a single addon here
  }
);

And check that the playground pane has both:

expect(content).to.include(mongoClientImport);
expect(content).to.include(queryImport);

[paula-stacho]

Can we add one more test? :) The include driver syntax and then add import statements test, which would do all the steps that the include driver syntax (only) does. And then call once again await vscode.commands.executeCommand(actionCommand.command); to emulate the case when a user runs the same playground to export to language and sees the state of the code lenses from the previous run,

Ah, thanks! I knew we said five tests but I couldn't remember what the last one was