-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show simpler uuid format VSCODE-470 #701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Mar 6, 2024
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
addaleax
reviewed
Mar 11, 2024
alenakhineika
approved these changes
Mar 13, 2024
addaleax
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/VSCODE-470
Description
Adding postprocessing in the Document Service, which replaces the extended
$binary
notation with$uuid
notation when presenting the document. Originally I thought we should reverse this onreplaceDocument
, but it looks like this is not necessary - I assume this is handled by the driver. I left the test case for regression, but perhaps it's not necessary.Aside of the new tests, I have tested this with the
all_types
collection ofcompass-data-sets/test
. I added a couple of new fields to the first document -nested_uuid
andnested_array_uuid
I tried
findOne()
find()
Checklist
Motivation and Context
Types of changes