fix: disconnect extension when server is closed VSCODE-536 #734
Conversation
|
Are we going to continue this pr re #737 ? |
|
@Anemy you probably missed it during standup, yes this PR was in the debug mode therefore there are some prints around. I will clean this and ping you when ready to take a look. |
alenakhineika
changed the title
src/test/suite/oidc.test.ts
Outdated
| @@ -398,6 +406,7 @@ suite('OIDC Tests', function () { | |||
| } | |||
|
|
|||
| await reAuthPromise; | |||
| await sleep(100); | |||
There was a problem hiding this comment.
Why do we need this sleep now? Can this be down without it?
There was a problem hiding this comment.
I wanted to ensure here that it is enough time to capture the closing event. Let's try without sleeps, and see how tests react.
There was a problem hiding this comment.
Yeah we do need sleep here otherwise the connection Is not yet closed, but I cleaned up some other places that you have mentioned.
There was a problem hiding this comment.
Instead of sleep we can use something like a waitFor with a timeout that keeps increasing, that way we will complete in 5ms if the end condition is already met.
Description
Bump some minor dependencies and fix VSCODE-536.
Checklist
Motivation and Context
Types of changes