Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(telemetry): update new connection telemetry VSCODE-560 #764

Merged
merged 5 commits into from
Jul 29, 2024
Merged

feat(telemetry): update new connection telemetry VSCODE-560 #764

merged 5 commits into from
Jul 29, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jul 29, 2024 •
edited
Loading

Description

  • Add missing props
  • Use isAtlas() check from dataService.instance() that does atlasVersion check
  • atlas_host_id -> atlas_hostname
  • Bump some minor deps

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika marked this pull request as ready for review July 29, 2024 14:48
@alenakhineika alenakhineika requested a review from Anemy July 29, 2024 15:10
Anemy
Anemy approved these changes Jul 29, 2024
View reviewed changes
src/telemetry/connectionTelemetry.ts Outdated Show resolved Hide resolved
@alenakhineika alenakhineika merged commit 20fceb3 into main Jul 29, 2024
5 checks passed
@alenakhineika alenakhineika deleted the VSCODE-560-update-new-connection-telemetry branch July 29, 2024 16:28
alenakhineika added a commit that referenced this pull request Aug 12, 2024
@alenakhineika @github-actions
@mcasimir @Anemy
chore: sync with main (#773)
feaaa7c 
* fix: remove changelog from the bundle VSCODE-551 (#758)

* Update changelog (#759)

Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com>

* Update changelog (#761)

Co-authored-by: alenakhineika <16307679+alenakhineika@users.noreply.github.com>

* feat(telemetry): report host_id for atlas COMPASS-8092 (#763)

* feat(telemetry): report host_id for atlas in VSCode COMPASS-8092

* test: add atlas host test and clean up

* feat(telemetry): update new connection telemetry VSCODE-560 (#764)

* feat(telemetry): update new connection telemetry VSCODE-560

* refactor: remove server_os

* refactor: rename to atlas_hostname

* docs: add comment

* refactor(telemetry): use resolved srv from topology VSCODE-563 (#765)

* Update changelog (#766)

Co-authored-by: alenakhineika <16307679+alenakhineika@users.noreply.github.com>

* feat(telemetry): handle IPv6 addresses when parsing hostnames VSCODE-585 (#769)

* feat(telemetry): handle IPv6 addresses when parsing hostnames VSCODE-585

* test: fallback to original uri

* chore: reduce bundle size and add modules to externals

* chore(deps): remove unused auto-prefixer (#771)

* chore: use Node.js 20 in CI VSCODE-586 (#770)

* chore: use Node.js 20 in CI VSCODE-586

* fix: try to resolve a regression of out of memory crashes of webpack

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com>
Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @Anemy