feat: improve the format of the participant answer VSCODE-582 #804
Conversation
alenakhineika
deleted the
VSCODE-582-improve-format-of-participant-answer
branch
|
|
||
| await this._openInResultPane(evaluateResponse.result); | ||
|
|
||
| return Promise.resolve(true); |
There was a problem hiding this comment.
[nit] I don't believe we need the Promise.resolve here since we're already in an async context.
| return Promise.resolve(true); | |
| return true; |
| if ( | ||
| !selections || | ||
| !Array.isArray(selections) || | ||
| (selections.length === 1 && this._getSelectedText(selections[0]) === '') | ||
| ) { |
There was a problem hiding this comment.
I know this is code that didn't change in this PR, but it's counterintuitive to me that we need to do these evaluations here, considering we already have this._selectedText. I would expect that this condition is equivalent to !this._selectedText.
| } | ||
|
|
||
| return this._evaluatePlayground(); | ||
| return this._evaluatePlayground(codeToEvaluate); |
There was a problem hiding this comment.
[nit] With the current code structure, we may be passing undefined here, while _evaluatePlayground expects string. My suggestion would be to declare the type of codeToEvaluate and either return early in an else clause for the if-statement on line 690, or fallback to an empty string.
|
Ugh, didn't notice the PR was merged prior to posting my comments - they're not blocking and can be addressed as a drive-by in the future. |
Description
Checklist
Motivation and Context
Types of changes