feat(participant): Add telemetry for user feedback VSCODE-601 #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
nirinchev
changed the title
| telemetryTrackStub | ||
| .getCalls() | ||
| .map((call) => call.args[0]) | ||
| .filter((arg) => arg === 'Participant Welcome Shown').length; |
There was a problem hiding this comment.
Can we maybe convert this to an individual test? something like tracks the participant welcome shown telemetry in the suite('telemetry',...) section?
There was a problem hiding this comment.
Hey, sorry, I had accidentally committed that test - it's part of another branch and I got my wires crossed when doing some rebasing and merging.
|
CI is also failing with a weird error I haven't seen before. |
|
The CI build should be fixed when #813 is merged and then main is merged into the copilot branch. |
nirinchev
force-pushed
the
ni/participant-telemetry-welcome
branch
from
7d16f2e to
978de40
Compare
nirinchev
commented
Sep 10, 2024
| handleUserFeedback(feedback: vscode.ChatResultFeedback): void { | ||
| this._telemetryService.trackCopilotParticipantFeedback({ | ||
| feedback: chatResultFeedbackKindToTelemetryValue(feedback.kind), | ||
| reason: feedback.unhelpfulReason, |
There was a problem hiding this comment.
If the additions API doesn't make it to stable before we release, we can extract the unhelpful reason as:
let unhelpfulReason: String | undefined;
if ('unhelpfulReason' in feedback) {
unhelpfulReason = feedback.unhelpfulReason as String | undefined;
}
Anemy
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of VSCODE-575 - reporting telemetry for usage of the chat participant component covering the user feedback functionality VSCode provides. The
unhelpfulReasonfield is part of thechatParticipantAdditionsAPI proposal - we may need to tweak the code slightly if it doesn't get promoted to stable before we're ready to publish the extension.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes