Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new connection form #815

Merged
merged 4 commits into from
Oct 8, 2024
Merged

fix: use new connection form #815

merged 4 commits into from
Oct 8, 2024

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Sep 13, 2024

Description

Update to the new Connection Form.

It should work the same, minor changes are the subtitle and horizontal line above the button.
Screenshot 2024-09-30 at 15 22 26
Screenshot 2024-09-30 at 15 22 26

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@paula-stacho paula-stacho changed the title wip fix: use new connection form Sep 13, 2024
@paula-stacho paula-stacho marked this pull request as ready for review September 30, 2024 13:36
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Left one q and one suggestion (not blocker, maybe better if we do it separate another time)

package.json Outdated Show resolved Hide resolved
src/connectionController.ts Show resolved Hide resolved
@paula-stacho paula-stacho merged commit bfa57d4 into main Oct 8, 2024
5 checks passed
@paula-stacho paula-stacho deleted the COMPASS-7762 branch October 8, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants