Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(participant): update anchor rendering to use markdown link instead of html a tag VSCODE-616 #826

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Sep 23, 2024

VSCODE-616

We would show characters in the url as we streamed them in until the full <a> tag was built. This fixes that by using the markdown link format for running our clickable commands. [text](link)

@Anemy Anemy requested a review from alenakhineika September 23, 2024 15:32
@alenakhineika
Copy link
Contributor

Nice!! Could you pls also change docs links the same way? https://github.com/mongodb-js/vscode/blob/VSCODE-528-mongodb-copilot/src/participant/participant.ts#L1137

@Anemy Anemy merged commit 4902f04 into VSCODE-528-mongodb-copilot Sep 23, 2024
3 checks passed
@Anemy Anemy deleted the VSCODE-616-improve-anchor-rendering branch September 23, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants