chore(participant): add maxTimeMS to sample #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
approved these changes
Sep 23, 2024
| @@ -700,7 +700,7 @@ export default class ParticipantController { | |||
| query: {}, | |||
| size: amountOfDocumentsToSample, | |||
| }, | |||
| { promoteValues: false }, | |||
| { promoteValues: false, maxTimeMS: 10_000 }, | |||
alenakhineika
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the maxTimeMS option for the sample we have in the participant. In the past, for collections with many documents, and atlas data lake, sample could take a really long time. We want to avoid that, especially as there's no way to cancel this at the moment besides ending the chat or restarting VSCode.
We should have maxTimeMS set on all of our requests, outside of playgrounds, in our extension. Created VSCODE-617 for that.