feat(participant): export to a playground VSCODE-574 #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SCODE-574-export-to-playground
Anemy
reviewed
Sep 24, 2024
Anemy
reviewed
Sep 24, 2024
Anemy
reviewed
Sep 24, 2024
nirinchev
approved these changes
Sep 24, 2024
Comment on lines
+1236
to
+1241
| token, | ||
| }), | ||
| new Promise<undefined>((resolve) => | ||
| token.onCancellationRequested(() => { | ||
| resolve(undefined); | ||
| }) |
There was a problem hiding this comment.
We're already passing the cancellation token to getChatResponseContent - why do we need the extra promise here?
There was a problem hiding this comment.
It doesn't seem that the token passed to the await model.sendRequest(messages, {}, token) terminates the request to the model and the model returns a result anyway. I want to investigate this more separately and maybe file the ticket to vscode.
Anemy
reviewed
Sep 25, 2024
Anemy
reviewed
Sep 25, 2024
Anemy
approved these changes
Sep 26, 2024
…SCODE-574-export-to-playground # Conflicts: # src/participant/participant.ts # src/test/suite/participant/participant.test.ts
…playground # Conflicts: # src/editors/playgroundController.ts # src/participant/participant.ts # src/participant/prompts/schema.ts # src/telemetry/telemetryService.ts # src/test/suite/editors/playgroundController.test.ts # src/test/suite/participant/participant.test.ts # src/test/suite/telemetry/telemetryService.test.ts
…playground # Conflicts: # src/participant/prompts/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert the full text from the active editor or selected lines of code written in the input language to the Shell language and open a new MongoDB playground with the generated code.
Checklist
Motivation and Context
Types of changes