feat(chat): show errors if there are issues when getting databases & collections to pick VSCODE-610 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de into gagik/add-test-filtering
…de into gagik/one-database-handling
gagik
commented
Nov 4, 2024
gagik
commented
Nov 4, 2024
nirinchev
reviewed
Nov 4, 2024
…-js/vscode into gagik/no-database-or-collection-error
…abase-or-collection-error
…-collection-handling
Anemy
reviewed
Nov 5, 2024
src/participant/participant.ts
Outdated
| log.error('No databases found'); | ||
| if (databases === undefined) { | ||
| stream.markdown( | ||
| vscode.l10n.t('An error occurred when getting the databases.') |
There was a problem hiding this comment.
Can we surface the error to users here? Something like permission issues is more transparent then.
There was a problem hiding this comment.
good point, not sure how to word it right. could something like "An error occurred while getting the databases. You may lack the necessary permissions. work or we can be even more explicit?
Co-authored-by: Rhys <Anemy@users.noreply.github.com>
…e-or-collection-error
…-collection-handling
…e-or-collection-error
Anemy
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better handling of 0 collections/databases and errors to #863. Instead of silently quitting, it shows the error.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes