-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chat): update schema assistant prompt to handle empty and short prompts better VSCODE-648 #874
Conversation
@@ -1300,21 +1313,6 @@ suite('Participant Controller Test Suite', function () { | |||
}); | |||
}); | |||
|
|||
test('without a prompt it asks for the database name without pinging ai', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this behavior becomes outdated; unless I am overlooking something, we do not gain too much by asking for the namespace if the user just runs /schema
. It'd be nicer to show an explainer first to help them discover the syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly this was intentional. We want the user to be able to get the schema of a collection by just writing /schema
and then clicking their namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I see. I can see how it's convenient but this does also make it hard for a user to actually discover what the /schema
command expects as an argument (something which we could definitely instead handle by introducing something like /help
or equivalent for internal extension info or questions). Seems like the only way to discover that you can also mention another collection or ask a question, etc. with the /schema
is through reading documentation.
I will remove the empty message response and see if the new rule works good enough when the prompt is empty
The new rule actually works pretty great even with empty prompts in my manual testing, so I'll revert the changes for empty prompt and just go ahead with the rule change. |
Description
Sometimes, when using the /query command to build a query, and then at some point using the /schema to get information about the schema of a collection without opening a new chat window, Copilot keeps thinking that a user wants to build a query. This PR tries to fix this by introducing a blank message case handling and modifying the prompt to make it clearer the schema command should always output schemas.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes