-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): add leaf connection icons inside playground VSCODE-650 #885
Conversation
fonts/mongodb-icons.woff
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can either have this font generated in CI or just do it ourselves at changes? I feel like this is a small enough file and one we will likely not touch often (and would also require package.json
updates) so perhaps it's fine just having this as part of repo files?
* https://code.visualstudio.com/api/references/icons-in-labels | ||
*/ | ||
async function main(): Promise<void> { | ||
const font = await webfont({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth it to have a external dev dependency / script for this. We can potentially utilize Vscode's support for icons fonts for i.e. easily having different color versions of the same icons and, as in this case, easily including icons in different places. Open to discussing this if there are other ideas though; at least for codelenses the need for an icon font is unavoidable so we could either ask design to make it or generate it from this script as done here.
The link from the comment:
https://code.visualstudio.com/api/references/icons-in-labels
We discussed that with @GaurabAryal and figured color could be cool in terms of encouraging people to click on them for this specific case. |
Co-authored-by: Alena Khineika <alena.khineika@mongodb.com>
This adds a script to generate an icon font from the SVGs we have and use them inside VSCode, specifically the playground connection codelens.