Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): add leaf connection icons inside playground VSCODE-650 #885

Merged
merged 18 commits into from
Nov 28, 2024

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Nov 25, 2024

This adds a script to generate an icon font from the SVGs we have and use them inside VSCode, specifically the playground connection codelens.

@gagik gagik changed the base branch from main to gagik/query-codelens November 25, 2024 10:38
Copy link
Contributor Author

@gagik gagik Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can either have this font generated in CI or just do it ourselves at changes? I feel like this is a small enough file and one we will likely not touch often (and would also require package.json updates) so perhaps it's fine just having this as part of repo files?

* https://code.visualstudio.com/api/references/icons-in-labels
*/
async function main(): Promise<void> {
const font = await webfont({
Copy link
Contributor Author

@gagik gagik Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth it to have a external dev dependency / script for this. We can potentially utilize Vscode's support for icons fonts for i.e. easily having different color versions of the same icons and, as in this case, easily including icons in different places. Open to discussing this if there are other ideas though; at least for codelenses the need for an icon font is unavoidable so we could either ask design to make it or generate it from this script as done here.
The link from the comment:
https://code.visualstudio.com/api/references/icons-in-labels

@gagik gagik changed the title feat(playground): Added leaf connection icons inside playground VSCODE-650 feat(playground): add leaf connection icons inside playground VSCODE-650 Nov 25, 2024
package.json Outdated Show resolved Hide resolved
@alenakhineika
Copy link
Contributor

Maybe the style of icons would look more aligned if the ai icon also didn't have a color like the connected icon?

Screenshot 2024-11-27 at 14 26 46

@gagik
Copy link
Contributor Author

gagik commented Nov 27, 2024

Maybe the style of icons would look more aligned if the ai icon also didn't have a color like the connected icon?
Screenshot 2024-11-27 at 14 26 46

We discussed that with @GaurabAryal and figured color could be cool in terms of encouraging people to click on them for this specific case.

Co-authored-by: Alena Khineika <alena.khineika@mongodb.com>
Base automatically changed from gagik/query-codelens to main November 28, 2024 13:02
@gagik gagik merged commit 98b526f into main Nov 28, 2024
6 checks passed
@gagik gagik deleted the gagik/add-icons branch November 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants