-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connect): can not select files on the connection form VSCODE-658 #898
Merged
alenakhineika
merged 13 commits into
main
from
VSCODE-658-fix-file-picker-connection-form
Dec 10, 2024
Merged
fix(connect): can not select files on the connection form VSCODE-658 #898
alenakhineika
merged 13 commits into
main
from
VSCODE-658-fix-file-picker-connection-form
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icker-connection-form
gagik
approved these changes
Dec 6, 2024
addaleax
requested changes
Dec 6, 2024
nirinchev
reviewed
Dec 7, 2024
addaleax
reviewed
Dec 8, 2024
addaleax
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Electron 32.0 removed support for the
path
property of the Web File object in favor of thewebUtils.getPathForFile
method (electron blog). We can not importdialog
andwebUtils
from 'electron' in the sandboxed webview microsoft/vscode#235284. To work around this, we use a custom dialog provider that uses webview APIs to send a message to the extension process to open the electron file dialog and listen for the response to get the file path and send them to the electron file input backend.Checklist
Motivation and Context
Types of changes