fix(playground): add better handling and tracking for export to playground errors VSCODE-666 #906
+125
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Dec 20, 2024
addaleax
approved these changes
Dec 20, 2024
|
Failing test seems unrelated so going ahead with merge. |
|
@gagik, could you please create a ticket to investigate this failing OIDC test? This failure is not flaky and happens all the time, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportToPlayground can error in many ways; one way you can reproduce it in the editor is to do:
and it'll likely silently do nothing and log an error on our end.
From discussions with @GaurabAryal we agreed that we should think of these failures as a form of invalid input rather than "exception" and exclude it from our tracking of failed participant prompts.
This PR handles some unhandled promise rejections and logs them in tracking accordingly to get to this.