This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Move PE sync into LastOperation #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabritsius
force-pushed
the
improve-pe-sync
branch
from
595fd9a
to
4d58005
Compare
fabritsius
force-pushed
the
improve-pe-sync
branch
from
4d58005
to
12af8e2
Compare
fabritsius
requested review from
jamesbroadhead,
jasonmimick and
priyolahiri
jasonmimick
approved these changes
Sep 8, 2021
pkg/broker/instance_operations.go
Outdated
| @@ -332,14 +291,37 @@ func (b *Broker) populateConnections(connections []mongodbatlas.PrivateEndpointC | |||
| return connections | |||
| } | |||
|
|
|||
| func privateEndpointIsPlanned(provider string, name string, planEndpoits privateendpoint.PrivateEndpoints) bool { | |||
There was a problem hiding this comment.
What does "IsPlanned" refer to here? like we expect it? what are those conditions? some notes here would help maintainability
There was a problem hiding this comment.
Here it just means that the endpoint with a given name and provider is in the plan. Thought it's self-explanatory but happy to add extra comments.
fabritsius
force-pushed
the
improve-pe-sync
branch
from
1ab4bd7
to
6004b24
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.