minor: remove time transitive dep and clock feature flag from chrono
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @roccodev, thanks for the PR! It looks like |
|
Disabling the feature worked, though it's still needed for tests as they use |
patrickfreed
approved these changes
Nov 8, 2021
isabelatkinson
approved these changes
Nov 8, 2021
patrickfreed
changed the title
time transitive dep from chronotime transitive dep and clock feature flag from chrono
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
chronodepends on a really old version oftime, which is affected by CVE-2020-26235.This dependency is withheld by the
oldtimefeature inchrono, which is enabled by default.Unfortunately, Cargo doesn't support disabling specific default features just yet, so the only way to get rid of the default feature is to re-import them all.
Code-wise, all tests seem to pass and I couldn't find any re-exports of the
timecrate (or evenchrono's replacements, for that matter), so this shouldn't break the API.