RUST-1592 Support decimal128 to/from human-readable strings #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/extjson/models.rs
Outdated
| impl Decimal128 { | ||
| pub(crate) fn parse(self) -> extjson::de::Result<crate::Decimal128> { | ||
| self.value.parse().map_err(|err| { | ||
| dbg!(err); |
There was a problem hiding this comment.
is this left over from debugging?
There was a problem hiding this comment.
Whoops, yes, fixed.
src/decimal128.rs
Outdated
Comment on lines
78
to
83
| const BIAS: i16 = 6176; | ||
| const TINY: i16 = -6176; | ||
| const MAX: i16 = 6111; | ||
|
|
||
| const UNUSED_BITS: usize = 2; | ||
| const PACKED_WIDTH: usize = 14; |
There was a problem hiding this comment.
can we add comments on these consts (and same below) indicating what they represent?
There was a problem hiding this comment.
Good thought, done.
| decimal_str = if rest.is_empty() { "0" } else { rest }; | ||
|
|
||
| // Check decimal precision | ||
| { |
There was a problem hiding this comment.
what's the purpose of this separated scope?
There was a problem hiding this comment.
Just making sure that len doesn't accidentally leak into other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1592
This adds support for the standard human-readable string traits (
DisplayandFromStr) toDecimal128via an intermediateParsedDecimal128struct, as well as using such in the extjson format. While it's possible to generate/parse the strings directly from the packed binary representation, I opted for the intermediate struct because it's way more readable and it'll be useful if we ever want to support more operations.