This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
DEVHUB-585: Fix withPrefix Usage for Article Assets #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jestapinski
added a commit
that referenced
this pull request
May 4, 2021
… Add TS (#792) * DEVHUB-546 [Part 1] Strapi-based Author Page (No Article Grid) (#732) * Add first working tag page for authors * WIP first author page * Add test and transform for pipeline * DEVHUB-546: Pull in Snooty Articles (#733) * Working author pages * Update test data * Avoid making a page twice * DEVHUB-545 [Part 1]: Basic Article Rendering Pipeline (#743) * Begin scaffolding strapi/article work * Set up scaffolding for a potential pipeline * WIP pipeline * WIP pipeline * Use a new template for Strapi * Add in support for more fields * Enumerate OG * Add back in other articles at build time * Add notes for next iteration * Skip twitter for now * DEVHUB-545 [Part 2]: Add Authors, Twitter (#750) * Clean up some fields in transform * Add authors into article * Add Twitter * Move twitter to transform * Add articles to author tag page * Remove cleanup note * Cleanup commentary * Use id vs _id * DEVHUB-545: Add Headings to TOC (#751) * Fix bad merge * DEVHUB-622: Use Single "Article" Interface, Add TS Support (#779) * Test TS in Autobuilder * Add TS support at build time * WIP using a class for strapi articles * Begin to use class for Snooty articles * Use a single rendering template * Add config support for TS * Add a default for the twitter node * Add twitter creator * Remove unused var * Skip test we will be fixing later * Cleanup functions in class defn * Add module content * Fix accidental typo * DEVHUB-585 (Part 1): Support All Articles on Learn/Tag Pages (#780) * Use single means of building a page * Add description to interface and render card lists * Clean up and add to learn page * Add some typing for author/tag pages * Implement sorting * Add sorting disclaimer * Fix search results to use Article interface * Get filters working again * Add _id field * Fix CI tests * Fix all tests * DEVHUB-585: Add Strapi Articles to Search Indexing, RSS Feed (#781) * Add strapiArticles to search RSS * Add strapi articles to RSS feed * Fix images on staging (#782) * DEVHUB-635: Use Local Plugin for Strapi publicationState, fix prefixPath on dev (#784) * WIP move to using a local plugin * Cleanup plugins, fix pathPrefix logic bug * Expose publication state via ENV * Shorten package.json * DEVHUB-631: Add support for author, tag pages (#789) * WIP getting author pages in order * Add tag mapping * Begin cleaning * More cleaning * Fix a bug for bios * Remove unused code * Extract new logic into new modules * Remove dupe code * Rename snooty author page * Add first test * Add test for author parsing * xit flaky test for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging Link
This PR fixes a bug in migrating to the
Articleinterface wherewithPrefixwas being applied inappropriately. Now we use it at build time for assets.