Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(NODE-4804): Improve migration guide notes #522

Merged
merged 9 commits into from
Nov 23, 2022
Merged

docs(NODE-4804): Improve migration guide notes #522

merged 9 commits into from
Nov 23, 2022

Conversation

nbbeeken
Copy link
Contributor

Description

Improving the docs, follow up for #518

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4804-improve-migration-docs branch from 6b81b36 to 19edcb5 Compare November 22, 2022 19:26
nbbeeken
nbbeeken commented Nov 23, 2022
View reviewed changes
Copy link
Contributor Author

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! (can't approve my own PR 😅)

@dariakp dariakp merged commit d705d75 into main Nov 23, 2022
@dariakp dariakp deleted the NODE-4804-improve-migration-docs branch November 23, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp Awaiting requested review from dariakp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp