Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4905): double precision accuracy in canonical EJSON #548

Merged
merged 3 commits into from
Jan 4, 2023
Merged

fix(NODE-4905): double precision accuracy in canonical EJSON #548

merged 3 commits into from
Jan 4, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 3, 2023

Description

What is changing?

Fixes the precision in EJSON canonical output for $numberDouble

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken mentioned this pull request Jan 3, 2023
Merged
5 tasks
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 4, 2023
@nbbeeken nbbeeken requested a review from durran January 4, 2023 15:06
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 4, 2023
@durran durran merged commit e0dbb17 into main Jan 4, 2023
@durran durran deleted the NODE-4905-fix-double-precision-main branch January 4, 2023 20:21
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @baileympearson