ESLint plugin 🦨 #2044
Open
ESLint plugin 🦨 #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f081fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -52 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
bruugey
reviewed
Jan 25, 2024
bruugey
reviewed
Jan 25, 2024
| 'plugin:storybook/recommended', | ||
| 'prettier', |
There was a problem hiding this comment.
should we add a basic rule inside of our plugin that we can turn on in this PR?
There was a problem hiding this comment.
Not that wouldn't result in a bunch of lint errors...
There was a problem hiding this comment.
I'd have to write a rule that we 100% follow right now
There was a problem hiding this comment.
Enabled "no-indirect-imports", which we have to follow otherwise rollup won't build
stephl3
reviewed
Mar 7, 2024
| import { isTestFile } from '../utils/isTestFile'; | ||
| import { RuleContext } from '../utils/RuleContext'; | ||
|
|
||
| const VERBS = ['is', 'are', 'has', 'should', 'did', 'does', 'will', 'use']; |
There was a problem hiding this comment.
do we want to include show or hide?
There was a problem hiding this comment.
Technically, following the strict pattern this establishes, you'd want to write shouldShow, willHide, or isShown etc. That said, I'm not super stuck the technicalities, and we can add whatever verbs we want here
TheSonOfThomp
force-pushed
the
adam/eslint-plugin
branch
from
728d4c4
to
ba80868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Creates a new package
@lg-tools/eslint-pluginThis enables us to create custom ESLint rules for both internal & external use.
(There was not a whole lot of online documentation around how to do this with the Typescript syntax tree, so I wrote this post: https://medium.com/@thesonofthomp/writing-a-custom-eslint-plugin-with-typescript-08d0e01726d2)