LG-4341: Add 72px spacing token #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e72bb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bruugey
approved these changes
Jun 13, 2024
bruugey
reviewed
Jun 13, 2024
| @@ -15,6 +15,7 @@ const spacing = { | |||
| 1200: 48, | |||
| 1400: 56, | |||
| 1600: 64, | |||
| 1800: 72, | |||
There was a problem hiding this comment.
is this the right number... it's only 6 away from 1600 so i think it shoudl be 1750 not 1800
There was a problem hiding this comment.
This should be correct:
18 x 4 = 72
16 x 4 = 64
There was a problem hiding this comment.
@bruugey it's 8 away
1800 / 100 = 72 / 4 = 18
bruugey
requested changes
Jun 13, 2024
|
Size Change: +9 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
TheSonOfThomp
approved these changes
Jun 13, 2024
| '@leafygreen-ui/tokens': minor | ||
| --- | ||
|
|
||
| Adds 72px spacing token |
There was a problem hiding this comment.
nit: maybe add what the token key is here
bruugey
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-4341
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes