LG-4338: Normalizes Modal size property #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78ff44d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bruugey
changed the title
bruugey
changed the title
shaneeza
reviewed
Jun 18, 2024
| @@ -87,6 +87,20 @@ const ModalView = React.forwardRef( | |||
| fallbackFocus: `#${closeId}`, // tests fail without a fallback. (https://github.com/focus-trap/focus-trap-react/issues/91) | |||
| }; | |||
|
|
|||
| let size: ModalSize = ModalSize.Default; | |||
There was a problem hiding this comment.
Could you do something like,
size = ModalSize[sizeProp] ?? ModalSize.Default
There was a problem hiding this comment.
nvm, i don't think thats correct
There was a problem hiding this comment.
or maybe something like this so you don't have to list every size
const exists = Object.values(ModalSize).includes(size);
const size = exists ? size : ModalSize.Default
There was a problem hiding this comment.
good call - i can do this
|
Size Change: +41 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
LG-4338
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes