LG-4446: refactor PopoverContext and replace PortalContext #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2bfe54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +97 B (+0.01%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/po-props-context
branch
from
6630f5b
to
d69090d
Compare
tsck
reviewed
Aug 16, 2024
packages/date-picker/src/shared/components/MenuWrapper/MenuWrapper.tsx
Outdated
Show resolved
Hide resolved
stephl3
added a commit
that referenced
this pull request
Sep 3, 2024
* PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated * Replace PortalContext with newly extended PopoverContext * Changesets * Add todo in select spec and update todos with jira tix
stephl3
added a commit
that referenced
this pull request
Sep 16, 2024
* PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated * Replace PortalContext with newly extended PopoverContext * Changesets * Add todo in select spec and update todos with jira tix
stephl3
added a commit
that referenced
this pull request
Oct 10, 2024
* PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated * Replace PortalContext with newly extended PopoverContext * Changesets * Add todo in select spec and update todos with jira tix
stephl3
added a commit
that referenced
this pull request
Oct 11, 2024
* PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated * Replace PortalContext with newly extended PopoverContext * Changesets * Add todo in select spec and update todos with jira tix
3 tasks
stephl3
added a commit
that referenced
this pull request
Nov 4, 2024
* PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated * Replace PortalContext with newly extended PopoverContext * Changesets * Add todo in select spec and update todos with jira tix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
PopoverContext, marksisPopoverOpenandsetIsPopoverOpendeprecatedModalis refactored to useOverlayContextPopoverContextto include additional propsdismissModeandonDismissprops toPopover,Popoverwill be refactored to consume allPopoverContextpropsPortalContextis replaced withPopoverContext🎟 Jira ticket: LG-4446
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes🧪 How to test changes
Copyablefor any unexpected regressionsCopyButtoninCodefor any unexpected regressionsModalfor any unexpected regressionsPopoverfor any unexpected regressions