LG-4525: popover-v12 code mod #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6520e5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
force-pushed
the
steph/po-code-mods
branch
from
7e740ac
to
c133311
Compare
|
Size Change: +92 B (+0.01%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Sep 20, 2024
tools/codemods/src/codemods/consolidate-popover-usePortal-renderMode-props/transform.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Sep 20, 2024
tools/codemods/src/utils/transformations/addJSXAttributes/addJSXAttributes.ts
Show resolved
Hide resolved
shaneeza
reviewed
Sep 20, 2024
tools/codemods/src/codemods/consolidate-popover-usePortal-renderMode-props/transform.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Sep 20, 2024
There was a problem hiding this comment.
This looks great! A few comments I have:
- Can you update the README to include this codemod? We should also remove the current codemods in the README because those currently are not consumer-facing.
- Should we also add a section in
Popover's README about this codemod? - You mentioned before about creating codemods for components that consume
Popoversuch asSelect,Tooltip, etc. What's the plan for those components? We could technically add all those components into this codemode. We can create an array of components that need updating and loop through them in the transformer file. - Were you able to test this locally with
yarn lg codemod consolidate-usePortal-into-renderMode <path>?
done!
I have some README changes in PR #2482 that I'd want to build off of. I will revisit this with work in this ticket
great, I updated the code mod to cover those components as well
I tested it locally on the LGUI repo, and it's able to correctly modify most instances. It errors on a few unique cases which I might expect it to but curious what degree of effectiveness we should expect / be aiming for:
|
stephl3
force-pushed
the
steph/po-code-mods
branch
from
6bd427a
to
54664af
Compare
stephl3
commented
Oct 8, 2024
tools/codemods/src/codemods/consolidate-popover-usePortal-renderMode-props/transform.ts
Outdated
Show resolved
Hide resolved
stephl3
force-pushed
the
LG-4121-popover-refactor
branch
from
6c8a4cd
to
3cfece1
Compare
stephl3
force-pushed
the
steph/po-code-mods
branch
from
54664af
to
0c1e5fb
Compare
stephl3
force-pushed
the
steph/po-code-mods
branch
from
01fdd0f
to
fab3612
Compare
stephl3
changed the title
stephl3
commented
Oct 21, 2024
tools/codemods/src/utils/transformations/removeJSXAttributes/removeJSXAttributes.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Oct 22, 2024
|
|
||
| const WrappedPopover = () => { | ||
| return ( | ||
| /* Please manually update from prop: usePortal to prop: renderMode */ |
stephl3
force-pushed
the
steph/po-code-mods
branch
from
0b07e37
to
9133382
Compare
shaneeza
reviewed
Oct 22, 2024
tools/codemods/src/codemods/consolidate-props/tests/consolidate-props.output.tsx
Show resolved
Hide resolved
shaneeza
reviewed
Oct 22, 2024
tools/codemods/src/utils/transformations/removeJSXAttributes/removeJSXAttributes.ts
Show resolved
Hide resolved
shaneeza
reviewed
Oct 23, 2024
I ran it in the |
shaneeza
reviewed
Oct 23, 2024
My only concern is making sure that the codemods are imported/transpiled correctly in an external project. Sometimes we can miss errors because we're testing external facing tools in the same repo where it exists. |
stephl3
force-pushed
the
steph/po-code-mods
branch
from
2ed7bbd
to
2d1cbb1
Compare
sounds good! I've ran it in leafygreen-ui-private repo. And here is the run from the design repo
|
shaneeza
approved these changes
Oct 25, 2024
stephl3
added a commit
that referenced
this pull request
Nov 4, 2024
* Add addJSXAttributes code mod util * Update consolidateJSXAttributes util to handle edge case * Add removeJSXAttributes code mod util * Fix comment utils * Export utils from utils/transformations * Add popover-v12 codemod * Changeset * Fix build type * Clean up comments * Update docs * Add commentOverride * Update transform.config.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
consolidateJSXAttributesutilinsertJSXCommentutiladdJSXAttributesutilremoveJSXAttributesutilpopover-v12code mod🎟 Jira ticket: LG-4525
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes