[WIP] Table Updates #2506
Draft
[WIP] Table Updates #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: +95 B (+0.01%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
shaneeza
commented
Oct 16, 2024
packages/table/src/Table/Table.tsx
Outdated
| 'data-lgid': lgidProp = LGIDS.root, | ||
| ...rest | ||
| }: TableProps<T>, | ||
| containerRef: ForwardedRef<HTMLDivElement>, | ||
| ) => { | ||
| const baseFontSize: BaseFontSize = useUpdatedBaseFontSize(baseFontSizeProp); | ||
| const { theme, darkMode } = useDarkMode(darkModeProp); | ||
| //TODO: find a better way to do all these checks |
There was a problem hiding this comment.
maybe make a hook that returns all of this
…/table-multiline-support
…green-ui into shaneeza/table-memoized
…en-ui into shaneeza/table-multiline-support
shaneeza
commented
Nov 4, 2024
| ...rowsCopy[i], | ||
| id: `${rowsCopy[i].id}-expandedContent`, | ||
| original: { | ||
| // TODO: move outside of original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
WIP - Lots of cleaning up to do and things are still changing.
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes