Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-4658: Compact Button #2535

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kraenhansen
Copy link
Member

✍️ Proposed changes

Adds a compact prop to the Button component, which removes unwanted whitespace around the content of the button when displaying a glyph. See the Jira ticket for more context.

🎟 Jira ticket: LG-4658

✅ Checklist

For bug fixes, new features & breaking changes

  • I have added tests that prove my fix is effective or that my feature works:
    • Storybook arg combinations.
    • A TypeScript type failure assertion in packages/button/src/Button/Button.spec.tsx.
  • I have added necessary documentation (if appropriate)
  • I have run yarn changeset and documented my changes

For new components

  • I have added my new package to the global tsconfig
  • I have added my new package to the Table of Contents on the global README
  • I have verified the Live Example looks as intended on the design website.

🧪 How to test changes

Go to either of the "Large Size", "Default Size", "Small Size" or "X Small Size" pages under "Button" and scroll to the bottom to see examples of the new compact variants.

@kraenhansen kraenhansen requested a review from a team as a code owner November 1, 2024 14:36
@kraenhansen kraenhansen requested review from stephl3 and removed request for a team November 1, 2024 14:36
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 7a8b60c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@leafygreen-ui/confirmation-modal Patch
@lg-chat/message-feedback Patch
@leafygreen-ui/number-input Patch
@leafygreen-ui/split-button Patch
@leafygreen-ui/form-footer Patch
@leafygreen-ui/code Patch
@leafygreen-ui/button Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant