Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix active state w/ menu #305

Merged
merged 2 commits into from
Mar 6, 2020
Merged

fix active state w/ menu #305

merged 2 commits into from
Mar 6, 2020

Conversation

hswolff
Copy link
Collaborator

@hswolff hswolff commented Mar 6, 2020

Mostly from @DesignerDave's suggestions.

✍️ Proposed changes

🎟 Jira ticket: Name of ticket

🛠 Types of changes

  • Tooling (updates to workspace config or internal tooling)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have run yarn changeset and documented my changes
  • I have added my new package to the global tsconfig
  • I have added my new package to the Table of Contents on the global README

💬 Further comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2020

Size Change: -43 B (0%)

Total Size: 462 kB

Filename Size Change
packages/menu/dist/index.node.js 6.75 kB -21 B (0%)
packages/menu/dist/index.web.js 6.75 kB -22 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/badge/dist/index.node.js 1.92 kB 0 B
packages/badge/dist/index.web.js 1.92 kB 0 B
packages/box/dist/index.node.js 6.79 kB 0 B
packages/box/dist/index.web.js 6.83 kB 0 B
packages/button/dist/index.node.js 9.31 kB 0 B
packages/button/dist/index.web.js 9.35 kB 0 B
packages/card/dist/index.node.js 1.34 kB 0 B
packages/card/dist/index.web.js 1.34 kB 0 B
packages/checkbox/dist/index.node.js 74.1 kB 0 B
packages/checkbox/dist/index.web.js 74.1 kB 0 B
packages/code/dist/index.node.js 2.94 kB 0 B
packages/code/dist/index.web.js 2.94 kB 0 B
packages/emotion/dist/index.node.js 973 B 0 B
packages/emotion/dist/index.web.js 1.04 kB 0 B
packages/hooks/dist/index.node.js 2.44 kB 0 B
packages/hooks/dist/index.web.js 2.49 kB 0 B
packages/icon-button/dist/index.node.js 2.28 kB 0 B
packages/icon-button/dist/index.web.js 2.28 kB 0 B
packages/icon/dist/index.node.js 8.46 kB 0 B
packages/icon/dist/index.web.js 8.46 kB 0 B
packages/leafygreen-provider/dist/index.node.js 1.65 kB 0 B
packages/leafygreen-provider/dist/index.web.js 1.65 kB 0 B
packages/lib/dist/index.node.js 1.25 kB 0 B
packages/lib/dist/index.web.js 1.25 kB 0 B
packages/logo/dist/index.node.js 8.3 kB 0 B
packages/logo/dist/index.web.js 8.3 kB 0 B
packages/modal/dist/index.node.js 2.96 kB 0 B
packages/modal/dist/index.web.js 2.96 kB 0 B
packages/mongo-nav/dist/index.node.js 20.1 kB 0 B
packages/mongo-nav/dist/index.web.js 20.2 kB 0 B
packages/palette/dist/index.node.js 1.17 kB 0 B
packages/palette/dist/index.web.js 1.17 kB 0 B
packages/pipeline/dist/index.node.js 12.9 kB 0 B
packages/pipeline/dist/index.web.js 12.9 kB 0 B
packages/popover/dist/index.node.js 4.13 kB 0 B
packages/popover/dist/index.web.js 4.13 kB 0 B
packages/portal/dist/index.node.js 1.71 kB 0 B
packages/portal/dist/index.web.js 1.71 kB 0 B
packages/radio-box-group/dist/index.node.js 3.79 kB 0 B
packages/radio-box-group/dist/index.web.js 3.8 kB 0 B
packages/radio-group/dist/index.node.js 2.93 kB 0 B
packages/radio-group/dist/index.web.js 2.93 kB 0 B
packages/side-nav/dist/index.node.js 8.7 kB 0 B
packages/side-nav/dist/index.web.js 8.75 kB 0 B
packages/syntax/dist/index.node.js 21.7 kB 0 B
packages/syntax/dist/index.web.js 21.7 kB 0 B
packages/tabs/dist/index.node.js 9.51 kB 0 B
packages/tabs/dist/index.web.js 9.55 kB 0 B
packages/text-input/dist/index.node.js 3.19 kB 0 B
packages/text-input/dist/index.web.js 3.19 kB 0 B
packages/theme/dist/index.node.js 940 B 0 B
packages/theme/dist/index.web.js 940 B 0 B
packages/toggle/dist/index.node.js 4.29 kB 0 B
packages/toggle/dist/index.web.js 4.29 kB 0 B
packages/tooltip/dist/index.node.js 4.5 kB 0 B
packages/tooltip/dist/index.web.js 4.56 kB 0 B

compressed-size-action

@hswolff hswolff merged commit fd6408b into master Mar 6, 2020
@hswolff hswolff deleted the harry-fix-menu-focus branch March 6, 2020 21:06
bruugey pushed a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants