PD-549: Refactor Card component to be a styled wrapper for Box #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 5, 2020 13:32
dominoweir
commented
Mar 6, 2020
| | `as` | `HTML Tag` or `React Element` | Determines the root element. For example, `Link` or `a` tags can be supplied to replace `div` from being the DOM element that wraps the component. | `section` | | ||
| | `className` | `string` | Adds a className to the class attribute | | | ||
| | `children` | `node` | The children of the rendered inside of the `<Card/>` component. | | | ||
| Card is a styled wrapper for the Box component. Any properties you would pass to Box can also be passed to Card. |
There was a problem hiding this comment.
Not completely sure if this is the best wording, but I tried
|
Size Change: +11.9 kB (2%) Total Size: 474 kB
ℹ️ View Unchanged
|
|
Don't forget to fix the test suite @dominoweir |
DesignerDave
approved these changes
Mar 9, 2020
bruugey
pushed a commit
that referenced
this pull request
Aug 9, 2023
* initial commit * make Box root element of Card * thank u Brooke * fix Box exports * update readme and rename prop * yarn changeset * fix breaking tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Refactor Card component to be a styled wrapper for Box
🎟 Jira ticket: PD-549(https://jira.mongodb.org/browse/PD-549)
🛠 Types of changes
✅ Checklist
yarn changesetand documented my changes💬 Further comments